Skip to content

Conversation

kaibocai
Copy link
Member

@kaibocai kaibocai commented Jan 20, 2023

Issue describing the changes in this PR

resolves #96

Pull request checklist

  • My changes do not require documentation changes
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@kaibocai kaibocai changed the title Kaibocai/issue96 Implement suspend and resume client APIs Jan 20, 2023
@kaibocai kaibocai marked this pull request as ready for review January 20, 2023 22:44
@kaibocai
Copy link
Member Author

Integration tests passed on local on latest durabletask-sidecar.
Added two integration tests, one is testing suspend instance, one is testing suspend and resume instance. Please let me know if they are sufficient. Thank you.

@cgillum
Copy link
Member

cgillum commented Jan 20, 2023

@kaibocai great! So the next step for me is to update the sidecar container used by the CI. Can you also open an issue that tracks updating this documentation? https://learn.microsoft.com/en-us/azure/azure-functions/durable/durable-functions-instance-management?tabs=java#suspend-and-resume-instances-preview

@kaibocai
Copy link
Member Author

Create issue #105 to track document update

@kaibocai
Copy link
Member Author

kaibocai commented Feb 1, 2023

Hi @cgillum , I have updated the unit tests (combine redundant tests and add one for testing termination). I found an issue in sidecar for method waitForInstanceCompletion, I raised a PR at https://github.com/microsoft/durabletask-sidecar/pull/19 can you take a look? Thank you.

Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple small suggestions before merging.

@kaibocai kaibocai requested a review from kamperiadis February 1, 2023 21:05
@kaibocai kaibocai merged commit c303a12 into main Feb 1, 2023
@kaibocai kaibocai deleted the kaibocai/issue96 branch February 1, 2023 21:08
@kaibocai
Copy link
Member Author

kaibocai commented Feb 1, 2023

Updated the sidecar, all tests pass. Merging this PR!

kaibocai added a commit that referenced this pull request Apr 10, 2023
kaibocai added a commit that referenced this pull request Apr 10, 2023
@kanupriya15025
Copy link

@kaibocai @cgillum

  1. Can we also have a ticket to return the HTTP endpoints for suspend and resume in the HTTP Response we get after submitting an orchestrator?
  2. Also, the documentation is still not complete here : https://learn.microsoft.com/en-us/azure/azure-functions/durable/durable-functions-instance-management?tabs=java#suspend-and-resume-instances-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suspend and Resume client APIs
3 participants